Open
Conversation
2 tasks
gadenbuie
force-pushed
the
312-bslib-sidebar-resize
branch
from
71f34d4 to
daf5438
Compare
gadenbuie
changed the title
cpsievert
reviewed
May 9, 2023
inst/apps/312-bslib-sidebar-resize/tests/testthat/test-shinytest2.R
Outdated
Show resolved
Hide resolved
cpsievert
reviewed
May 12, 2023
schloerke
approved these changes
May 15, 2023
Contributor
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
I'm happy that it is automated. I'll let you and @cpsievert work out the details
cpsievert
reviewed
May 15, 2023
inst/apps/312-bslib-sidebar-resize/tests/testthat/test-shinytest2.R
Outdated
Show resolved
Hide resolved
Contributor
|
@gadenbuie do you know why these tests fail pretty consistently on Windows (and sometimes on Mac)? |
Member
Author
|
The Mac 3.6.3 errors are due to ggiraph I was just starting to try to figure out how to look into the Windows failures (any ideas?) |
cpsievert
approved these changes
May 19, 2023
Member
Author
|
There's some general flakiness in this PR that I want to resolve before merging. Carson and I talked through some options in person, one of which would be to do all of the sidebar size polling in the browser, rather than communicating back and forth via shinytest2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a manual testing app for plot and output resizing in sidebars (without cards).
Pairs with rstudio/bslib#566 where this behavior is improved for sidebars.
Expected behavior
In the app below, both the "static" ggplot2 output and the htmlwidget plotly plot output will stretch during the sidebar transition. The static plot will re-render when the transition is complete, so there's a small "snap" when the new plot is rendered. (No snap is seen in the case of an htmlwidget like plotly.)
All plots stretch during resize when the shared sidebar is toggled; only the sidebar in the local sidebar layout stretches when the local sidebar is toggled.
Kapture.2023-05-09.at.15.56.42.mp4
Failing behavior
When the behavior isn't present, neither the plot nor the htmlwidget's will update its width until after receiving a re-render event from the server.
Kapture.2023-05-09.at.15.55.44.mp4